Revert name change in required tests #2095
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #2095 +/- ##
=======================================
Coverage 83.34% 83.34%
=======================================
Files 353 353
Lines 81769 81769
Branches 8993 8993
=======================================
Hits 68148 68148
Misses 10796 10796
Partials 2825 2825 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
We may even keep the version-less one and drop python version in name. This way, when we bump toolchain the next time, we don't need to work around it again.
There was a problem hiding this comment.
but it seems that if you use a matrix, the value of the item in the matrix will be always appended so, we should remove the matrix from the tasks
There was a problem hiding this comment.
Yes. It seems the matrix has always only one argument and we can inline it.
If there is a real matrix, we can use an aggregation trick like https://github.com/fast/logforth/blob/7cad34bdc63a9692040143497ddbf346f5d10264/.github/workflows/ci.yml#L108-L124
3 participants
Revert name change in required tests
Description
Revert this change (0a37446#diff-b4c2a69650f9ac84008ad9f745859a645c9466350ffdfe5f919655039ee2e2c3L51) as it sets an incorrect name for required tests:
Status
Checklist (tick everything that applies)